[PATCH] D81784: [ELF] Resolve relocations in .debug_* referencing (discarded symbols or ICF folded section symbols) to tombstone values

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

I am happy with it. There is a small comment inside. other than that lgtm.



================
Comment at: lld/ELF/InputSection.cpp:932
+      // address selection entry). Use -2 instead.
+      if (name == ".debug_loc" || name == ".debug_ranges")
+        --tombstone;
----------------
I think it is better not to do string comparisons for every relocation pointing to deleted code. 
It is worth to move this name comparisons before the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81784/new/

https://reviews.llvm.org/D81784