[PATCH] D80677: [lld-macho] Handle framework search path, alongside library search path

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:144
+                                  opt::InputArgList &args) {
+  SmallVector<StringRef, 2> systemPaths = {"/usr/lib", "/usr/local/lib"};
+  getSearchPaths(paths, OPT_L, args, systemPaths);
----------------
int3 wrote:
> gkm wrote:
> > int3 wrote:
> > > nit: this can just a ctor call instead of an assignment
> > > 
> > > (actually the local variable itself isn't necessary if we take the parameter by const ref)
> > What is the syntax for eliding the local variable?
> ah, it looks like `SmallVectorImpl` doesn't have a ctor that takes an initializer list, but making the parameter a `const SmallVectorImpl<StringRef, 2> &` works
Sorry, I meant `const SmallVector<StringRef, 2> &`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80677/new/

https://reviews.llvm.org/D80677