[PATCH] D79962: Fix the verification of DIEs with DW_AT_ranges.

Wed Jun 17 20:31:10 PDT 2020

clayborg marked 2 inline comments as done.
clayborg added inline comments.

================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/verify_overlapping_cu_ranges.yaml:67
+
+# CHECK-NOT: error: DIE address ranges are not contained in its parent's ranges:
+# CHECK: Verifying .debug_info references...
----------------
clayborg wrote:
> jhenderson wrote:
> > Maybe it would be better to add `--implicit-check-not=error:` to FileCheck's invocation. That way, all errors will be detected, regardless of position, and will avoid this check passing spuriously in the future should the text of the message ever change.
> that is a good idea. I haven't used that flag before.
Actually can't include this because there is an error before this on line 44

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79962/new/

https://reviews.llvm.org/D79962