[PATCH] D81854: [InstCombine] Don't let an alignment assume prevent new/delete removals.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 14:35:08 PDT 2020


jdoerfert added a comment.

In D81854#2098885 <https://reviews.llvm.org/D81854#2098885>, @yamauchi wrote:

> In D81854#2096685 <https://reviews.llvm.org/D81854#2096685>, @jdoerfert wrote:
>
> > This is the right fix for alignment: D71739 <https://reviews.llvm.org/D71739>
> >
> > For all `assumes` (and later other stuff, think lifetime markers or annotations) you can check if the `User::isDroppable`, and eventually drop via `Value::dropDroppableUses` if you cannot update them properly.
>
>
> @lebedev.ri, @jdoerfert: I acknowledge D71739 <https://reviews.llvm.org/D71739>. What's the status of it? Are you open to having this patch as a temporary measure until that's checked in?


I pinged the other patch. It is basically ready, minor changes only. Let's wait a day or so and see if @Tyker responds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81854/new/

https://reviews.llvm.org/D81854





More information about the llvm-commits mailing list