[PATCH] D81326: lld: improve the `-arch` handling for MachO

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 14:02:18 PDT 2020


mgorny added a comment.

This change broke standalone builds of LLD:

  FAILED: MachO/CMakeFiles/lldMachO2.dir/Driver.cpp.o 
  /usr/lib64/ccache/bin/x86_64-pc-linux-gnu-g++ -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IMachO -I/var/tmp/portage/sys-devel/lld-11.0.0.9999/work/lld/MachO -I/var/tmp/portage/sys-devel/lld-11.0.0.9999/work/lld/include -Iinclude -I/usr/lib64/llvm/11/include  -O2 -pipe -fPIC -fvisibility-inlines-hidden -Werror=date-time -w -fdiagnostics-color -ffunction-sections -fdata-sections    -fno-exceptions -fno-rtti -MD -MT MachO/CMakeFiles/lldMachO2.dir/Driver.cpp.o -MF MachO/CMakeFiles/lldMachO2.dir/Driver.cpp.o.d -o MachO/CMakeFiles/lldMachO2.dir/Driver.cpp.o -c /var/tmp/portage/sys-devel/lld-11.0.0.9999/work/lld/MachO/Driver.cpp
  /var/tmp/portage/sys-devel/lld-11.0.0.9999/work/lld/MachO/Driver.cpp:30:10: fatal error: llvm/Config/config.h: No such file or directory
   #include "llvm/Config/config.h"
            ^~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.



================
Comment at: lld/MachO/Driver.cpp:30
 #include "llvm/BinaryFormat/Magic.h"
+#include "llvm/Config/config.h"
 #include "llvm/Object/Archive.h"
----------------
This file is not part of LLVM install, so including it breaks standalone builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81326/new/

https://reviews.llvm.org/D81326





More information about the llvm-commits mailing list