[PATCH] D81820: [ObjectYAML][ELF] Add support for emitting the .debug_abbrev section.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 11:18:46 PDT 2020


MaskRay added a comment.

In D81820#2094624 <https://reviews.llvm.org/D81820#2094624>, @Higuoxing wrote:

> OR
>
>   # CONTENT-NEXT: 0000: 01110125
>                         ^~       ULEB28 abbreviation code
>                           ^~     ULEB128 DW_TAG_compile_unit
>                             ^~   1-byte DW_CHILDREN_yes
>                               ^~ ULEB128 DW_AT_producer
>


This style looks good to me.  This is similar to `lld/test/ELF/mips-gp-ext.s`, which uses

  # ABS:      Contents of section .text:
  # ABS-NEXT:  00e0 3c080000 21080120 8f82ff08
  #                 ^-- %hi(_gp_disp)
  #                          ^-- %lo(_gp_disp)
  #                                   ^-- 8 - (0x200 - 0x100)
  #                                       G - (GP - .got)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81820/new/

https://reviews.llvm.org/D81820





More information about the llvm-commits mailing list