[PATCH] D81667: [RFC, FileCheck] Add precision to format specifier

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 09:40:54 PDT 2020


jdenny added a comment.

> Should the regex wildcard for a numeric variable definition with empty expression also respect the precision, i.e. #%.5u, VAR2: would be matched by (([1-9][0-9]+)? [0-9]{1,5})

I believe I followed the comments about matching behavior for an empty expression (scanf-like) vs. an expression (printf-like).  So the above question is about whether, in the empty-expression case, it's worthwhile to support a precision specified by `.` even though scanf does not support that.  Right?

I don't understand the above regex due to the space character after the `?`.  Was that intended?

Can you give some example inputs and explain the intended matching behavior for `#%.5u, VAR2:`?  Why is this behavior needed in FileCheck but not in scanf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81667/new/

https://reviews.llvm.org/D81667





More information about the llvm-commits mailing list