[PATCH] D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass

Scott Constable via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 07:31:35 PDT 2020


sconstab added a comment.

In D80964#2097227 <https://reviews.llvm.org/D80964#2097227>, @craig.topper wrote:

> It may also be worth noting that this new unoptimized pass is equivalent to the behavior of the mitigation implemented for gcc through binutils. Given that I wonder if it makes sense to use this pass at O1 <https://reviews.llvm.org/owners/package/1/> or O2 <https://reviews.llvm.org/owners/package/2/> and save the mostly costly analysis for O3 <https://reviews.llvm.org/owners/package/3/>.


I have seen some build systems use `-O2` for release builds. So if we go this route, maybe we could have unoptimized for `-O0` and `-O1`, and optimized for `-O2` and `-O3`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80964/new/

https://reviews.llvm.org/D80964





More information about the llvm-commits mailing list