[PATCH] D81803: [Support] PR42623: Avoid setting the delete-on-close bit for TempFile

Wed Jun 17 06:26:25 PDT 2020

rdwampler added a comment.

In D81803#2094020 <https://reviews.llvm.org/D81803#2094020>, @amccarth wrote:

> That commit (which was reviewed here https://reviews.llvm.org/D48051) suggests this wasn't about the occasional temp file not getting deleted.  It was to work around surprising behavior on Windows when a temp file is mapped into memory, which, as I recall, was the underlying cause in what appeared to be cache corruption for LTO.
>
> I think it best if @pcc and/or @inglorion weigh in.
>
> BTW, is it common to create temp files on a network drive?  Is that done in distributed build systems?  For a single-machine build, it would seem counter productive to use a network drive for a temp file.

I have a similar setup as described in here https://bugs.llvm.org/show_bug.cgi?id=42623 for local development. That bug report also includes a link to a GitHub issue where others where having the same issue. So, it's probably not uncommon to build on a drive attached as a network drive to a VM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81803/new/

https://reviews.llvm.org/D81803