[PATCH] D81994: [DWARFYAML][debug_addr] Use unsigned integer in Length, Version, etc. NFC.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 01:02:44 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/DWARFYAML.h:170
   dwarf::DwarfFormat Format;
-  Optional<yaml::Hex64> Length;
-  yaml::Hex16 Version;
-  Optional<yaml::Hex8> AddrSize;
-  yaml::Hex8 SegSelectorSize;
+  Optional<uint64_t> Length;
+  uint16_t Version;
----------------
I think length fields are generally better represented as hex, not decimal, so I wouldn't change those. I don't care much either way for the other fields.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81994/new/

https://reviews.llvm.org/D81994





More information about the llvm-commits mailing list