[PATCH] D81937: [llvm-readobj] - Do not crash when GnuHashTable->symndx is greater than the dynamic symbols count.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 01:02:42 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with nit.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-histogram.test:214
 ## Case A: the .hash table has no data to build histogram and it is skipped.
-##         (NBUCKET == 0x1 is a no-op: it does not change the number of buckets described with the "Bucket" key).
-# RUN: yaml2obj --docnum=5 -DNBUCKET=0x1 %s -o %t5.o
+##         (NBUCKET == 0x2 is a no-op: it does not change the number of buckets described with the "Bucket" key).
+# RUN: yaml2obj --docnum=5 -DNBUCKET=0x2 %s -o %t5.o
----------------
whilst you're modifying this line: "described with" -> "described by"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81937/new/

https://reviews.llvm.org/D81937





More information about the llvm-commits mailing list