[PATCH] D81527: [llvm-install-name-tool] Add `delete_rpath` option

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 2 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-delete-rpath.test:51-52
+
+# INDEX: Load command 4
+# INDEX-NEXT: cmd LC_SYMTAB
+
----------------
smeenai wrote:
> There's a bunch of special load commands whose indices are stored. Can we add tests for the other ones as well (in addition to LC_SYMTAB)?
Ok, to test this I have added a test `remove-lc-index-update.test`. The test uses the binary from `strip-all.yaml` (with additional modifications) as it already made use of all special Load Commands. Now, if the index is not updated properly, the binary either __crashes__ or __raises an assert error__. However, if the indices are set right, the binary will run and the LC indices will be updated appropriately (aka the test passes). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81527/new/

https://reviews.llvm.org/D81527