[PATCH] D81762: [CMake] Fix incorrect handling of get_target_property failure

[Christopher Tetreault via Phabricator via llvm-commits]

ctetreau updated this revision to Diff 271244.
ctetreau added a comment.

Apparently some falsey values are used elsewhere and it is not safe to just check if (NOT ${test_suite_folder})


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81762/new/

https://reviews.llvm.org/D81762

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -1428,7 +1428,7 @@
 
   add_dependencies(${test_suite} ${test_name})
   get_target_property(test_suite_folder ${test_suite} FOLDER)
-  if (NOT ${test_suite_folder} STREQUAL "NOTFOUND")
+  if (NOT ${test_suite_folder} STREQUAL "test_suite_folder-NOTFOUND")
     set_property(TARGET ${test_name} PROPERTY FOLDER "${test_suite_folder}")
   endif ()
 endfunction()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81762.271244.patch
Type: text/x-patch
Size: 546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200616/508f5acc/attachment.bin>