[PATCH] D81437: [CGP] Reset the debug location when promoting zext(s)

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Lgtm with minor nitpicks inline, thanks!



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2652
+  /// CGP does not check if instructions would be speculatively executed when
+  /// moved. Preserving the original location would pessimize the debugging
+  /// experience, as well as negatively impact the quality of sample PGO.
----------------
To quibble: s/would/could/ might be more fair, since we're conservatively dropping the location just in case the created instruction gets moved around after the fact -- it's just that this tends to happen a lot :). Also, maybe moving this to the TypePromotionAction class definition would serve as a more general warning?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81437/new/

https://reviews.llvm.org/D81437