[llvm] 1a1849c - [NFC] Use EXPECT_FALSE(...) in test rather than EXPECT_EQ(false, ...)

Christopher Tetreault via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 15:47:39 PDT 2020


Author: Christopher Tetreault
Date: 2020-06-16T15:47:23-07:00
New Revision: 1a1849c99b894aa20294713ba935a340ba181aa0

URL: https://github.com/llvm/llvm-project/commit/1a1849c99b894aa20294713ba935a340ba181aa0
DIFF: https://github.com/llvm/llvm-project/commit/1a1849c99b894aa20294713ba935a340ba181aa0.diff

LOG: [NFC] Use EXPECT_FALSE(...) in test rather than EXPECT_EQ(false, ...)

Summary: Silence GCC -Wconversion-null warning from GTest

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81976

Added: 
    

Modified: 
    llvm/unittests/IR/ModuleTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/IR/ModuleTest.cpp b/llvm/unittests/IR/ModuleTest.cpp
index 67338f797d3a..975427d08d48 100644
--- a/llvm/unittests/IR/ModuleTest.cpp
+++ b/llvm/unittests/IR/ModuleTest.cpp
@@ -112,7 +112,7 @@ TEST(ModuleTest, setProfileSummary) {
   std::unique_ptr<Module> M = parseAssemblyString(IRString, Err, Context);
   auto *PS = ProfileSummary::getFromMD(M->getProfileSummary(/*IsCS*/ false));
   EXPECT_NE(nullptr, PS);
-  EXPECT_EQ(false, PS->isPartialProfile());
+  EXPECT_FALSE(PS->isPartialProfile());
   PS->setPartialProfile(true);
   M->setProfileSummary(PS->getMD(Context), ProfileSummary::PSK_Sample);
   delete PS;


        


More information about the llvm-commits mailing list