[PATCH] D81976: [NFC] Use EXPECT_FALSE(...) in test rather than EXPECT_EQ(false, ...)

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 15:28:36 PDT 2020


ctetreau created this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Silence GCC -Wconversion-null warning from GTest


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81976

Files:
  llvm/unittests/IR/ModuleTest.cpp


Index: llvm/unittests/IR/ModuleTest.cpp
===================================================================
--- llvm/unittests/IR/ModuleTest.cpp
+++ llvm/unittests/IR/ModuleTest.cpp
@@ -112,7 +112,7 @@
   std::unique_ptr<Module> M = parseAssemblyString(IRString, Err, Context);
   auto *PS = ProfileSummary::getFromMD(M->getProfileSummary(/*IsCS*/ false));
   EXPECT_NE(nullptr, PS);
-  EXPECT_EQ(false, PS->isPartialProfile());
+  EXPECT_FALSE(PS->isPartialProfile());
   PS->setPartialProfile(true);
   M->setProfileSummary(PS->getMD(Context), ProfileSummary::PSK_Sample);
   delete PS;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81976.271231.patch
Type: text/x-patch
Size: 589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200616/fd64f8f4/attachment.bin>


More information about the llvm-commits mailing list