[PATCH] D81894: [llvm-readobj][COFF] add .llvm.call-graph-profile section dump

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 14:23:21 PDT 2020


zequanwu added inline comments.


================
Comment at: llvm/tools/llvm-readobj/COFFDumper.cpp:1973
+    else
+      consumeError(NameOrErr.takeError());
+
----------------
jhenderson wrote:
> Why `consumeError` rather than report the `Error` in some form?
Because some section may not have name, and we can just skip them. This for loop is used to find the section with the name `.llvm.call-graph-profile`, similar to the part of `.llvm_addrsig` above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81894/new/

https://reviews.llvm.org/D81894





More information about the llvm-commits mailing list