[PATCH] D81764: [flang] Add the Mangler module to flang lowering

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 13:12:26 PDT 2020


sameeranjoshi accepted this revision.
sameeranjoshi added a comment.

In D81764#2095904 <https://reviews.llvm.org/D81764#2095904>, @schweitz wrote:

> Rebase and update with the functional unittest.


LGTM.
Thanks for adding test.



================
Comment at: flang/lib/Lower/Mangler.cpp:57
+    const auto *iface = scope.parent().FindSymbol(symbol.name());
+    assert(iface && "Separate module proc must be declared");
+    return iface;
----------------
nit s/proc/procedure/ 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81764/new/

https://reviews.llvm.org/D81764





More information about the llvm-commits mailing list