[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

Baptiste Saleil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 12:05:29 PDT 2020


bsaleil added a comment.

In D76802#2086650 <https://reviews.llvm.org/D76802#2086650>, @phosek wrote:

> - http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/4263 I cannot reproduce this locally, but what I think is happening is that your bot doesn't build lld, but this test requires lld (because we need working `SHF_LINK_ORDER` support) so when we pass `-fuse-ld=lld`, it uses the system lld which is likely outdated since the error we're seeing is coming from the bitcode reader. I think that we should either remove https://github.com/llvm/llvm-project/blob/master/compiler-rt/CMakeLists.txt#L539 or introduce a new lit stanza that means "lld is not only available, but was built as part of this build and is up-to-date".


@phosek, we just updated the `clang-ppc64le-rhel` bot to lld 10.0.0, is that recent enough for `SHF_LINK_ORDER` support you need ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76802/new/

https://reviews.llvm.org/D76802





More information about the llvm-commits mailing list