[llvm] 91bec1d - GlobalISel: Make special case handling clearer

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 11:32:55 PDT 2020


Author: Matt Arsenault
Date: 2020-06-16T14:32:47-04:00
New Revision: 91bec1d385c3d460866f98828f3c4965d9a3289e

URL: https://github.com/llvm/llvm-project/commit/91bec1d385c3d460866f98828f3c4965d9a3289e
DIFF: https://github.com/llvm/llvm-project/commit/91bec1d385c3d460866f98828f3c4965d9a3289e.diff

LOG: GlobalISel: Make special case handling clearer

The special case here is really G_UNMERGE_VALUES, not G_EXTRACT. The
other opcodes can hardcode index 1 like G_EXTRACT.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h b/llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
index 25807fc3ff28..ba7034557a1a 100644
--- a/llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
+++ b/llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
@@ -812,10 +812,10 @@ class LegalizationArtifactCombiner {
     case TargetOpcode::G_ZEXT:
     case TargetOpcode::G_ANYEXT:
     case TargetOpcode::G_SEXT:
-    case TargetOpcode::G_UNMERGE_VALUES:
-      return MI.getOperand(MI.getNumOperands() - 1).getReg();
     case TargetOpcode::G_EXTRACT:
       return MI.getOperand(1).getReg();
+    case TargetOpcode::G_UNMERGE_VALUES:
+      return MI.getOperand(MI.getNumOperands() - 1).getReg();
     default:
       llvm_unreachable("Not a legalization artifact happen");
     }


        


More information about the llvm-commits mailing list