[PATCH] D57779: [SLP] Add support for throttling.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 08:16:10 PDT 2020


dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6191-6192
     return true;
-  }
+  } else if (SLPThrottling && R.findSubTree())
+    R.saveTree();
 
----------------
dtemirbulatov wrote:
> ABataev wrote:
> > dtemirbulatov wrote:
> > > ABataev wrote:
> > > > Why not try to vectorize a partial tree right here?
> > > hmm, we might have an opportunity to vectorize the whole tree with smaller Chain sizes or at vectorizeStores or while doing reductions.
> > Did you check that?
> yes, I can add a testcase for that.
For example, if we allow partial vectorization straight away we could see partial vectorization in test/Transforms/SLPVectorizer/X86/PR39774.ll without [[TMP3:%.*]] = add <8 x i32> [[SHUFFLE]], <i32 0, i32 55, i32 285, i32 1240, i32 1496, i32 8555, i32 12529, i32 13685> That because of later we would have opportinity to vectorize the whole tree.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779





More information about the llvm-commits mailing list