[PATCH] D57779: [SLP] Add support for throttling.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 07:42:49 PDT 2020


dtemirbulatov marked 2 inline comments as done.
dtemirbulatov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6191-6192
     return true;
-  }
+  } else if (SLPThrottling && R.findSubTree())
+    R.saveTree();
 
----------------
ABataev wrote:
> Why not try to vectorize a partial tree right here?
hmm, we might have an opportunity to vectorize the whole tree with smaller Chain sizes or at vectorizeStores or while doing reductions.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6492-6493
         Changed = true;
-      }
+      } else if (SLPThrottling && R.findSubTree(UserCost))
+        R.saveTree();
     }
----------------
ABataev wrote:
> Why not try to vectorize a partial tree right here?
we might have an opportunity to vectorize the whole tree with smaller Chain sizes at vectorizeStoreChain or while doing reductions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779





More information about the llvm-commits mailing list