[PATCH] D81937: [llvm-readobj] - Do not crash when GnuHashTable->symndx is greater than the dynamic symbols count.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 07:11:11 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-histogram.test:258
+## sizeof(.hash) == 0x14.
+        Value: 0x14
       - Tag:   DT_NULL
----------------
I had to fix this test case because this place was wrong and the code adds an assert:
`assert(DynamicSymCount >= symndx);` which is triggered if this test case is not fixed.

We still want to make this assert never happen. I've mentioned in the description that it
is related to `printGnuHashHistogram` and probably should be fixed independently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81937/new/

https://reviews.llvm.org/D81937





More information about the llvm-commits mailing list