[PATCH] D81829: [LangRef] Element-wise Integral Reduction Intrinsics

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see inline for grammar nits. Please remove "Reduction" from the title of this review too.

But we should wait at least a week before pushing in case there is more feedback here or on llvm-dev.



================
Comment at: llvm/docs/LangRef.rst:12115
+This is an overloaded intrinsic. You can use ``llvm.abs`` on any
+integer bit width, or any vector of integer elements.
+
----------------
Remove comma after "width".


================
Comment at: llvm/docs/LangRef.rst:12132
+The first argument is the value for which the absolute value is to be returned.
+This argument may be of any integer type, or a vector with integer element type.
+The return type must match the first argument type.
----------------
Remove comma after "type".


================
Comment at: llvm/docs/LangRef.rst:12136
+The second argument must be a constant and is a flag to indicate whether the
+result value of the '``llvm.abs``' intrinsic is a a
+:ref:`poison value <poisonvalues>` if the argument is statically or dynamically
----------------
typo: a a


================
Comment at: llvm/docs/LangRef.rst:12143-12144
+
+The '``llvm.abs``' intrinsic negates the argument, or each element of
+the argument if it is negative. If the argument is ``INT_MIN``, then the result
+is also ``INT_MIN`` if ``is_int_min_poison == 0`` and ``poison`` otherwise.
----------------
First line is a bit awkward to me. How about:
"Returns the magnitude (always positive) of the argument or each element of a vector argument."


================
Comment at: llvm/docs/LangRef.rst:12155
+This is an overloaded intrinsic. You can use ``@llvm.smax`` on any
+integer bit width, or any vector of integer elements.
+
----------------
Remove comma after "width".


================
Comment at: llvm/docs/LangRef.rst:12172
+
+The arguments (``%a`` and ``%b``) may be of any integer type, or a vector with
+integer element type. The argument types must match each other, and the return
----------------
Remove comma after "type".


================
Comment at: llvm/docs/LangRef.rst:12184
+This is an overloaded intrinsic. You can use ``@llvm.smin`` on any
+integer bit width, or any vector of integer elements.
+
----------------
Remove comma after "width".


================
Comment at: llvm/docs/LangRef.rst:12201
+
+The arguments (``%a`` and ``%b``) may be of any integer type, or a vector with
+integer element type. The argument types must match each other, and the return
----------------
Remove comma after "type".


================
Comment at: llvm/docs/LangRef.rst:12213
+This is an overloaded intrinsic. You can use ``@llvm.umax`` on any
+integer bit width, or any vector of integer elements.
+
----------------
Remove comma after "width".


================
Comment at: llvm/docs/LangRef.rst:12230
+
+The arguments (``%a`` and ``%b``) may be of any integer type, or a vector with
+integer element type. The argument types must match each other, and the return
----------------
Remove comma after "type".


================
Comment at: llvm/docs/LangRef.rst:12242
+This is an overloaded intrinsic. You can use ``@llvm.umin`` on any
+integer bit width, or any vector of integer elements.
+
----------------
Remove comma after "width".


================
Comment at: llvm/docs/LangRef.rst:12259
+
+The arguments (``%a`` and ``%b``) may be of any integer type, or a vector with
+integer element type. The argument types must match each other, and the return
----------------
Remove comma after "type".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81829/new/

https://reviews.llvm.org/D81829