[PATCH] D80915: [FileCheck] Implement * and / operators for ExpressionValue.

Tue Jun 16 03:17:19 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:1396-1397
+  Tester.initNextPattern();
+  ASSERT_FALSE(Tester.parsePattern("[[#sub(NUMVAR,7)]]"));
+  EXPECT_THAT_EXPECTED(Tester.match("11"), Succeeded());

----------------
paulwalker-arm wrote:
> jhenderson wrote:
> > Is there any particular reason you've moved the `sub` case later. It would help blame history if it was where it was before, and the new `div` case here.
> This fixes a mistake in my call patch as in general I've tried to keep references to FileCheck's predefined functions in alphabetical order. 
Okay, that's fine with me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80915/new/

https://reviews.llvm.org/D80915