[PATCH] D80915: [FileCheck] Implement * and / operators for ExpressionValue.

Tue Jun 16 02:09:30 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.

================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:1396-1397
+  Tester.initNextPattern();
+  ASSERT_FALSE(Tester.parsePattern("[[#sub(NUMVAR,7)]]"));
+  EXPECT_THAT_EXPECTED(Tester.match("11"), Succeeded());

----------------
Is there any particular reason you've moved the `sub` case later. It would help blame history if it was where it was before, and the new `div` case here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80915/new/

https://reviews.llvm.org/D80915