[PATCH] D81821: [AMDGPU] Make overlaps with ScratchRSrcReg fatal errors

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 01:36:56 PDT 2020


critson marked an inline comment as done.
critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:339
   if (StackPtrReg) {
+    if (isSubRegister(ScratchRSrcReg, StackPtrReg))
+      report_fatal_error("scratch resource registers overlap stack pointer");
----------------
arsenm wrote:
> This is only really an improvement for hand written MIR, and should go in the verifier?
This can occur at compile time on LLVM IR with an -sgpr-limit set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81821/new/

https://reviews.llvm.org/D81821





More information about the llvm-commits mailing list