[PATCH] D81855: [llvm-readobj] set --elf-cg-profile as alias of --cg-profile

Tue Jun 16 00:31:02 PDT 2020

jhenderson added a comment.

In D81855#2093336 <https://reviews.llvm.org/D81855#2093336>, @MaskRay wrote:

> You can click `Edit Related Revisions` and assign a parent revision for a child revision.

Also, if you mention in the patch description (possibly also comments) "Depends on DXXXXX" it will automatically create the link.

> Since `--cg-profile` is going to be the canonical option name, please rename `--elf-cg-profile` in tests. Keep one to demonstrate that it is an alias for `--cg-profile`.

I'd expect to see test\tools\llvm-readobj\ELF\call-graph-profile.test to be updated to use the new option, with two additional invocations using the old option (one each for llvm-readobj and llvm-readelf). Looks good apart from that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81855/new/

https://reviews.llvm.org/D81855