[PATCH] D81695: [flang] Turn off FLANG_ENABLE_WERROR by default

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In D81695#2093046 <https://reviews.llvm.org/D81695#2093046>, @sscalpone wrote:

> @isuruf Are there some warning that cannot be removed with reasonable effort?


I don't think this is about not willing to remove warnings, it is about what is the right default config.

Right for example now our MLIR bot does not show warnings with gcc-5 nor with clang-8, but for example clang-5 still wants extra braces:

  warning: suggest braces around initialization of subobject [-Wmissing-braces]
   std::array<StringRef, 2> silentAttrNames{getIndexingMapsAttrName(),
                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
                                            {

Having default to Werror may lead to broken build for users because we can't test every possible combination all the time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81695/new/

https://reviews.llvm.org/D81695