[PATCH] D81782: [lit] Allow for tests to have non-parsed requirements

[Casey Carter via Phabricator via llvm-commits]

CaseyCarter marked 5 inline comments as done.
CaseyCarter added inline comments.


================
Comment at: llvm/utils/lit/tests/unparsed-requirements.py:1
+# RUN: %{python} %s %{inputs}/unparsed-requirements 2> %t.err
+
----------------
ldionne wrote:
> Is `2> %t.err` necessary?
Nope - it's copy-pasta.


================
Comment at: llvm/utils/lit/tests/unparsed-requirements.py:8
+
+class CustomTest(Test):
+    def __init__(self, suite, path_in_suite, config, file_path = None):
----------------
ldionne wrote:
> I think this LGTM, but you should also test `xfails` and `unsupported`.
I was so shocked to get the test working that I forgot it wasn't complete!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81782/new/

https://reviews.llvm.org/D81782