[PATCH] D55682: [ELF] Support defining __start/__stop symbols as hidden

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 14:54:32 PDT 2020


MaskRay added a comment.

Please add a test, `startstop-visibility.s` (I would like start-stop-visibility.s, but some existing tests use the startstop- prefix).

Use `-triple=x86_64` and use `llvm-readelf -s` to check visibility. Check both `__start_foo` and `__stop_foo`. Don't add another `__start_bar`.

Please mention that GNU ld and gold from binutils 2.35 onwards will support the option (
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=cae64165f47b64898c4f1982d294862cfae89a47 )


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55682/new/

https://reviews.llvm.org/D55682





More information about the llvm-commits mailing list