[PATCH] D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked 3 inline comments as not done.
SouraVX added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.h:84-85
 
+  MCDwarfDwoLineTable *SplitLineTable;
+
 public:
----------------
dblaikie wrote:
> Rather than plumbing this through to every unit - might be better to go the other way, removing the existing plumbing into DwarfTypeUnit, and replace it with accessing this directly from DwarfDebug whenever needed. (since there's only one of them anyway - so we don't need to track different ones per-unit)
Sorry, not able to follow you here. `SplitLineTable` was already present in `DwarfTypeUnit` hence it was restricting the enablement for present case. 
So I moved it from there and promoted to `DwarfUnit` so that both case(`TypeUnit` and `debug_macro.dwo`) where `SplitLineTable` is required should be able to use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81476/new/

https://reviews.llvm.org/D81476