[PATCH] D81469: [DebugInfo/DWARF] - Report .eh_frame sections of version != 1.

Mon Jun 15 13:14:16 PDT 2020

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

In D81469#2084372 <https://reviews.llvm.org/D81469#2084372>, @grimar wrote:

> In D81469#2082410 <https://reviews.llvm.org/D81469#2082410>, @probinson wrote:
>
> > If the .eh_frame section contains contributions for multiple compilation units, the dumper should skip over the bad one and continue dumping at the next one.  In which case, you'd need only one test, with multiple units in it (imitating a linked executable).
>
>
> Sounds reasonable.
>
> But `Error DWARFDebugFrame::parse(DWARFDataExtractor Data)` returns errors for a few cases already,
>  e.g. for the case when something is wrong with the augmentation string. Instead it could provide a way to
>  report a warning (perhaps a warning callback) and continue dumping.
>
> Reimplementing the `DWARFDebugFrame::parse()` to support warnings should be done independently from this change I think?

That's fair.  LGTM, although it would be nice if you could leave a TODO comment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81469/new/

https://reviews.llvm.org/D81469