[PATCH] D81447: [llvm] Added support for stand-alone cmake object libraries.

Mon Jun 15 12:37:52 PDT 2020

mtrofin added a comment.

In D81447#2093437 <https://reviews.llvm.org/D81447#2093437>, @beanz wrote:

>

Sorry, just pushed - I can revert if needed.

> I have several concerns about this.
> 
> (1) This is likely going to cause issues for the Xcode builds. Xcode does not handle object libraries in a remotely sane way.

Ack - it also fails on windows, it seems, although I'm not sure if this (http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16497/steps/stage%201%20cmake/logs/stdio) isn't what it says it is - a stale cache. I'll try the XCode case locally (unless a bot picked it up already)

> (2) How does this work with LLVM development installations where we install the static libraries for use component-by-component? CMake doesn't install object libraries.

The use case has the object library be built in its container, and then that container is the item being installed. In other words, the object library shouldn't be consumed by anything else than its container.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81447/new/

https://reviews.llvm.org/D81447