[llvm] e51e827 - [Target/PPC] Fold inside an assertion.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 12:09:04 PDT 2020


Author: Davide Italiano
Date: 2020-06-15T12:08:57-07:00
New Revision: e51e82745e86b9bfd19ac17f13915a90b00d9655

URL: https://github.com/llvm/llvm-project/commit/e51e82745e86b9bfd19ac17f13915a90b00d9655
DIFF: https://github.com/llvm/llvm-project/commit/e51e82745e86b9bfd19ac17f13915a90b00d9655.diff

LOG: [Target/PPC] Fold inside an assertion.

Pointed out by dblaikie.

Added: 
    

Modified: 
    llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp b/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
index cd6bce24be5f..fb65e7320f2b 100644
--- a/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
+++ b/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
@@ -242,9 +242,8 @@ PPCMCCodeEmitter::getMemRI34PCRelEncoding(const MCInst &MI, unsigned OpNo,
 
     const MCSymbolRefExpr *SRE = cast<MCSymbolRefExpr>(LHS);
     (void)SRE;
-    const MCConstantExpr *CE = cast<MCConstantExpr>(RHS);
-    (void)CE;
-    assert(isInt<34>(CE->getValue()) && "Value must fit in 34 bits.");
+    assert(isInt<34>(cast<MCConstantExpr>(RHS)->getValue()) &&
+           "Value must fit in 34 bits.");
 
     // Currently these are the only valid PCRelative Relocations.
     assert((SRE->getKind() == MCSymbolRefExpr::VK_PCREL ||


        


More information about the llvm-commits mailing list