[PATCH] D79830: Add support of __builtin_expect_with_probability

[Erich Keane via Phabricator via llvm-commits]

erichkeane accepted this revision.
erichkeane added a comment.

Please fix the 'nit' when committing.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2207
+                        llvm::RoundingMode::Dynamic, &loseInfo);
+    (void)EvalSucceed;
+    llvm::Type *Ty = ConvertType(ProbArg->getType());
----------------
Nit, move this cast next to the assert, its a common pattern in LLVM, so moving it away makes its purpose pretty unknown.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79830/new/

https://reviews.llvm.org/D79830