[PATCH] D81820: [ObjectYAML][ELF] Add support for emitting the .debug_abbrev section.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

I asked around how we should comment individual bytes.

lichway gave an alternative:

  # CONTENT-NEXT:                0000:  01 11 01 25
                                        ~~ ~~ ~~ ~~
                                         ^  ^  ^  ^
                                         |  |  |  |
        ULEB128  abbreviation code ______|  |  |  |
        ULEB128  DW_TAG_compile_unit _______|  |  |
         1-byte  DW_CHILDREN_yes ______________|  |
        ULEB128  DW_AT_producer __________________|
  
                                        0E 13 05 03
                                        ~~ ~~ ~~ ~~
                                         ^  ^  ^  ^
                                         |  |  |  |
        ULEB128  DW_FORM_strp ___________|  |  |  |
        ULEB128  DW_AT_language ____________|  |  |
        ULEB128  DW_FORM_data2 ________________|  |
        ULEB128  DW_AT_name ______________________|

wanders: Not radically different, but if you put the comment above instead it will read from top instead of from bottom.

(Request changes just to make sure these suggestions are considered and the comments should be improved if you think any suggestion is favorable.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81820/new/

https://reviews.llvm.org/D81820