[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

[Richard Barton via Phabricator via llvm-commits]

richard.barton.arm added a comment.

Summary of discussion in F18 <https://reviews.llvm.org/F18> developers call on 15/06/20

- Flang’s current use of asserts in these specific cases (‘provably’ unreachable code not possible to hit from user error) clearly doesn’t match the LLVM guidelines. This patch brings it in line in that particular regard.
- The arguments against this patch going in would need to either:
  - Argue a specific technical reason why Flang should not follow the guidelines for cases like this
  - Argue that a change in LLVM coding guidelines is needed so that Flang becomes compliant.
- No argument has been put forward of these types so the patch should be submitted to align the code to the guidelines
- This does not block either of the two above arguments being made in future.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507