[PATCH] D80865: [TableGen] defm in a loop is not final (bug fix)

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 06:28:53 PDT 2020


simon_tatham added inline comments.


================
Comment at: llvm/test/TableGen/foreach-multiclass.td:98
 
   foreach _ = !if(b, [0], []<int>) in
   def B;
----------------
Of course, we've got a proper `if` statement now! I wonder if it's worth checking that this construction works with that as well as with the `foreach` dodge?

(It should, because if I remember, `if` expands to that anyway under the hood. But just in case the implementation changes in future, perhaps.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80865/new/

https://reviews.llvm.org/D80865





More information about the llvm-commits mailing list