[PATCH] D81712: [NFC][PowerPC] Add a multiclass for fsetcc to define them in a uniform way

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 03:46:43 PDT 2020


nemanjai added a comment.

This is a nice refactor. The only thing I would like to see is a statement to indicate that you have ensured that `PPCGenDAGISel.inc` is identical before and after this patch.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3896
 
+
 // This must be in this file because it relies on patterns defined in this file
----------------
Unrelated and unnecessary whitespace addition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81712/new/

https://reviews.llvm.org/D81712





More information about the llvm-commits mailing list