[PATCH] D81822: [DA] propagate loop live-out values that get used in a branch

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Analysis/DivergenceAnalysis.cpp:111-114
+  if (DeferredTerminators.count(&Term)) {
+    DeferredTerminators.erase(&Term);
+    return true;
+  }
----------------
I think it might be cleaner to put this in `compute` just before the call to `updateTerminator`. It feels wrong to make `updateTerminator` non-const, and the relationship between Worklist and DeferredTerminators seems clearer if instructions are removed from them in the same place, in `compute`. But I'll happily defer to others who are more familiar with this code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81822/new/

https://reviews.llvm.org/D81822