[PATCH] D81829: [LangRef] Element-wise Integral Reduction Intrinsics

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri created this revision.
lebedev.ri added reviewers: lattner, spatel, arsenm, mjacob, hfinkel, Ayal.
lebedev.ri added a project: LLVM.
Herald added a subscriber: wdng.
lebedev.ri edited the summary of this revision.
nikic added a reviewer: nikic.
nikic added a comment.

I find the naming of these intrinsics somewhat unintuitive. My first association with `llvm.reduce.smax` is that this is the non-experimental version of `llvm.experimental.vector.reduce.smax`, because reduction (to me) carries a strong vector reduction connotation. I can still see how these might be "reductions" for min/max (in which case I would expect the intrinsics to be variadic though), but not seeing the analogy at all for abs().

I would suggest to instead call these just `llvm.smax`, `llvm.abs` etc, which seems more in line with existing integer intrinsic names.


This is the proposed wording for the `[RFC] Integer Intrinsics for abs, in unsigned/signed min/max`.

Link to RFC:
https://lists.llvm.org/pipermail/llvm-dev/2020-June/142257.html

Proposed alive2 implementation: https://github.com/AliveToolkit/alive2/pull/353


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81829

Files:
  llvm/docs/LangRef.rst

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81829.270680.patch
Type: text/x-patch
Size: 5249 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200615/f38544d0/attachment.bin>