[PATCH] D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE

Mon Jun 15 02:08:35 PDT 2020

jhenderson added a comment.

Looks reasonable on the surface, but I don't have the Mach-O knowledge to confirm it, so best get someone else to give the LGTM.

================
Comment at: llvm/test/tools/llvm-objcopy/MachO/code_signature_lc.test:4
+# RUN: cmp %t %t.copy
+
+--- !mach-o
----------------
MaskRay wrote:
> Does this test need CHECK lines?
I don't think so, strictly? `cmp` does the job fine, since we know the load command is in the input (citation: presumably some yaml2obj test), and it does a binary diff.

That being said, a check line might be helpful to prevent user error in the input.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81768/new/

https://reviews.llvm.org/D81768