[PATCH] D81669: [PowerPC] Support constrained fp operation for scalar sitofp/uitofp

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8205
+
+static SDValue getFPNode(unsigned Opc, EVT VT, SDValue Op, SDValue Chain,
+                         SelectionDAG& DAG, bool Strict) {
----------------
You don't need to have two overloaded functions, but with one to have an array of ops.


================
Comment at: llvm/test/CodeGen/PowerPC/fp-strict-conv-f128.ll:12
 ; RUN: llc -verify-machineinstrs -ppc-asm-full-reg-names < %s -mcpu=e500 \
 ; RUN:   -mtriple=powerpc-unknown-linux-gnu -mattr=spe | FileCheck %s \
 ; RUN:   -check-prefix=SPE
----------------
Add a run with fp128 enabled.


================
Comment at: llvm/test/CodeGen/PowerPC/fp-strict-conv-f128.ll:25
 
+declare fp128 @llvm.experimental.constrained.sitofp.f128.i32(i32, metadata, metadata)
+declare fp128 @llvm.experimental.constrained.sitofp.f128.i64(i64, metadata, metadata)
----------------
How about the f128/ppc_fp128 -> i128 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81669/new/

https://reviews.llvm.org/D81669