[PATCH] D81775: [COFF] Add .llvm.call-graph-profile and `--coff-cg-profile` dumpping

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/MC/MCParser/COFFAsmParser.cpp:307
+bool COFFAsmParser::ParseDirectiveCGProfile(StringRef, SMLoc) {
+  StringRef From;
+  SMLoc FromLoc = getLexer().getLoc();
----------------
If the code duplicates ELFAsmParser, please move it to `AsmParser::`


================
Comment at: llvm/test/MC/AsmParser/directive_cgprofile.s:2
 # RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s
+# RUN: llvm-mc -triple x86_64-pc-win32 %s | FileCheck %s -check-prefix=COFF-CHECK
 
----------------
`FileCheck %s` (reuse `CHECK:`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81775/new/

https://reviews.llvm.org/D81775