[PATCH] D81230: Correctly report modified status for LoopIdiomRecognize

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

@efriedma I believe @serge-sans-paille had D80916 <https://reviews.llvm.org/D80916> in mind here, which provides a stronger guarantee, or at least has the potential to provide it. Of course, just returning true would be more conservative, and make little difference in practice.



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1030
+  }
+};
+
----------------
Rather than explicitly calling `clean()` in all early-return paths, maybe do this in `~ExpandedValueCleaner()` automatically, and add a `commit()` method or so for the single success path, that clears the vector?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81230/new/

https://reviews.llvm.org/D81230