[PATCH] D81728: [InstCombine] Add target-specific inst combining

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 13 05:54:20 PDT 2020


nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:149
 
+  Value *instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const {
+    return nullptr;
----------------
Actually implementing this would require us to export the `InstCombiner` class, which is part of `InstCombineInternal.h`. I don't think we would want to do this in its current form. This would require a larger refactoring to separate out the implementation and API portions of InstCombine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81728/new/

https://reviews.llvm.org/D81728





More information about the llvm-commits mailing list