[PATCH] D81607: BreakCriticalEdges for callbr indirect dests

[Bill Wendling via Phabricator via llvm-commits]

void added a comment.

In D81607#2091105 <https://reviews.llvm.org/D81607#2091105>, @efriedma wrote:

> > While it's not the case right now, I think it would be very desirable to allow this in the future for callbr. Some of the other envisioned use-cases for callbr would require the ability to pass the target block in as a value (in which case there may be no blockaddress arguments directly on the callbr.)
>
> Being indecisive about this is creating a mess in both the LLVM IR and MachineInstrs.  I've repeatedly asked about this, and gotten contradictory answers every time.  We need to make a decision here and stick to it.


My vote is for allowing non-blockaddresses as acceptable input to a callbr. (I would suggest using the indirect destination list, but that list is unordered.) I don't think there's a good enough reason to require only blockaddresses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81607/new/

https://reviews.llvm.org/D81607