[PATCH] D81777: [llvmbuild] --enable-optional-components should not be a substring match

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 17:08:49 PDT 2020


dsanders created this revision.
dsanders added reviewers: bogner, ddunbar.
Herald added a subscriber: kristof.beyls.
Herald added a project: LLVM.
dsanders added a child revision: D81778: [llvmbuild] Add optional_libraries, i.e. a dependency iff the target is enabled.
dsanders added a parent revision: D80960: Support other llc-like tools in update_llc_test_checks.py.
dsanders removed a parent revision: D80960: Support other llc-like tools in update_llc_test_checks.py.
dsanders added a parent revision: D81773: [llvmbuild] Allow OptionalLibrary's to be enabled by default and disabled.

enabled_optional_components was a string so given something like
'AArch64AsmParser' it would also match components like 'AsmParser'.
There's nothing in tree where it matters. It came up while trying use
this feature to replace a downstream hack that removes unused subcomponents
from our dylib.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81777

Files:
  llvm/test/LLVMBuild/enable-optional-component/Input/LLVMBuild.txt
  llvm/test/LLVMBuild/enable-optional-component/Input/lib/IR/Function.cpp
  llvm/test/LLVMBuild/enable-optional-component/Input/lib/LLVMBuild.txt
  llvm/test/LLVMBuild/enable-optional-component/enable-optional-component.test
  llvm/utils/llvm-build/llvmbuild/main.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81777.270547.patch
Type: text/x-patch
Size: 4965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200613/1456081a/attachment.bin>


More information about the llvm-commits mailing list