[PATCH] D81765: Don't hoist very large static allocas to the entry block during inlining

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Independent of the thresholds, I'd be very cautious about turning a static alloca into a dynamic alloca.  Our code generation isn't very sophisticated in a lot of cases; it often requires a "base pointer" to be generated in a fixed register.  This leads to a issues even if the alloca never runs: there's a performance penalty due to allocating the base pointer, and we can potentially break inline asm. We don't want to be doing that; if it comes down to either emitting a dynamic alloca or refusing to inline, refusing to inline is probably better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81765/new/

https://reviews.llvm.org/D81765